Skip to content

test(e2e): expand Podman provider test coverage#280

Merged
skevetter merged 1 commit into
mainfrom
2a7d-20db-podman-e2e-tests
May 14, 2026
Merged

test(e2e): expand Podman provider test coverage#280
skevetter merged 1 commit into
mainfrom
2a7d-20db-podman-e2e-tests

Conversation

@skevetter

@skevetter skevetter commented May 13, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Expand Podman e2e tests from 2 to 12 test cases across 5 context groups
  • Add compose, build, lifecycle commands, agent delivery, exec, and cleanup tests for both rootless and rootful Podman
  • Tests use existing framework helpers and testdata from Docker provider tests
  • Depends on PR ci: add Linux rootless and rootful Podman to e2e test matrix #278 (Linux Podman CI matrix entries)

Summary by CodeRabbit

Release Notes

  • Tests
    • Expanded end-to-end test coverage for Podman provider, including both rootless and rootful modes
    • Added comprehensive test scenarios: workspace creation with existing images, multistage builds, lifecycle commands, agent delivery, SSH operations, and cleanup validation

Review Change Stack

@skevetter
skevetter enabled auto-merge (squash) May 13, 2026 20:36
@netlify

netlify Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 93d6034
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a050a9674e8e500089331cd

@coderabbitai

coderabbitai Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4aacd572-790f-49ae-9304-b9eb123370f6

📥 Commits

Reviewing files that changed from the base of the PR and between f5c7361 and 93d6034.

📒 Files selected for processing (1)
  • e2e/tests/up/provider_podman.go
📝 Walkthrough

Walkthrough

This PR expands e2e test coverage for the podman provider by adding structured test suites for both rootless and rootful modes. Both test paths follow identical scenarios: basic workspace startup with existing images, multi-stage Docker builds, post-create command execution with SSH verification, agent delivery, arbitrary container command execution, and workspace cleanup validation. Imports are updated to include strings and adopt gomega assertions.

Changes

Podman Provider E2E Tests

Layer / File(s) Summary
Import updates and test dependencies
e2e/tests/up/provider_podman.go		 Added strings import and switched to gomega assertion library for use in test bodies.
Rootless podman test suite
e2e/tests/up/provider_podman.go		 Structured ginkgo test contexts covering: basic workspace startup, multi-stage Docker builds, post-create command lifecycle validation via SSH output, agent delivery with SSH verification, container command execution via SSH, and workspace cleanup assertions.
Rootful podman test suite
e2e/tests/up/provider_podman.go		 Identical structured test suite as rootless mode; adjusted #nosec comment on wrapper-script to reference execute-permission requirement; covers the same startup, build, lifecycle, agent, exec, and cleanup scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • devsy-org/devsy#278: Updates CI matrix to install and run the expanded up-provider-podman tests in rootless vs rootful modes with appropriate DOCKER_HOST configuration for rootful execution.

Suggested labels

size/m

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'test(e2e): expand Podman provider test coverage' accurately and concisely summarizes the main change: expanding end-to-end test coverage for the Podman provider from 2 to 12 test cases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
test(e2e): expand Podman provider e2e test coverage
93d6034 
Add build, lifecycle command, agent delivery, exec, and cleanup tests
for both rootless and rootful Podman contexts. Tests reuse existing
docker testdata and follow the same framework patterns as
provider_docker.go.
@skevetter
skevetter force-pushed the 2a7d-20db-podman-e2e-tests branch from b4b0445 to 93d6034 Compare May 13, 2026 23:34
@coderabbitai coderabbitai Bot added the size/m label May 13, 2026
@skevetter
skevetter merged commit 7a31acc into main May 14, 2026
103 of 104 checks passed
@skevetter
skevetter deleted the 2a7d-20db-podman-e2e-tests branch May 14, 2026 00:36
@coderabbitai coderabbitai Bot mentioned this pull request May 14, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/l size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skevetter